This repository was archived by the owner on Oct 27, 2021. It is now read-only.
Conversation
adriantirea
reviewed
Jun 3, 2021
adriantirea
left a comment
adriantirea
left a comment
Contributor
There was a problem hiding this comment.
Pay attention to fmuResourceFile encoded string. It will be received as encoded URI. To use it you need to decode it. It will be the responsibility of the FMU to decode it
You need more code to be consistent. Follow the example of instanceName which is a string exactly like fmuResourceFile.
- check that allocation succeeded. See line 172.
- you need to free the memory in fmi2FreeInstance.
- checked that allocation succeeded - free memory when freeing instance
Author
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To work with the resources folder in the model the temporary resource location is needed.
I added it to the modelInstance Struct and copy it during initialization.